Skip to content
This repository has been archived by the owner on Jan 2, 2020. It is now read-only.

declare missing dependencies #1059

Open
kalikaneko opened this issue Apr 20, 2017 · 2 comments
Open

declare missing dependencies #1059

kalikaneko opened this issue Apr 20, 2017 · 2 comments
Assignees

Comments

@kalikaneko
Copy link
Contributor

kalikaneko commented Apr 20, 2017

the following dependencies are needed by pixelated but not declared in setup.py:

  • chardet
  • whoosh
@deniscostadsc deniscostadsc self-assigned this Apr 21, 2017
@deniscostadsc
Copy link
Contributor

Hi @kalikaneko

I did some experiments, that can be seen here.

I thought it could be a good ideia to parse requirements file, because we like to change a lot requirements file. It worked to get the packages, but it cannot install from the github repository, is installing from Pypi. I was looking at 'dependency_links' field on the setup to fix that but the first approach didn't worked. We'll have a look on it soon.

@kalikaneko
Copy link
Contributor Author

parsing the requirements file, in my experience (and according to some previous people in pixelated too) is not a good idea. when you introduce pinning in the requirements file, you are injecting the pinning to the setup.py and therefore complicating the life of the maintainer for whatever platform that wants to distribute the package.

this was recommended by some people in the pixelated team in the past:
https://caremad.io/posts/2013/07/setup-vs-requirement/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants