Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload size unknown #3162

Closed
cloo opened this issue Jan 17, 2022 · 4 comments
Closed

File upload size unknown #3162

cloo opened this issue Jan 17, 2022 · 4 comments

Comments

@cloo
Copy link

cloo commented Jan 17, 2022

Pixelfed often fails to upload videos due to low default upload sizes.
Failure results in a generic "unexpected error":
220117-185333

Also by default, allowed file sizes are not stated in server description.
I propose to state max file size near upload button, e.g. with or instead text ("share up to 50 photos or videos").

220117-185950

In case of choosing too big files, a dialog could show a meaningful warning about too large file selection even before brutally trying to upload them. You know how this normally feels, no need to describe I guess.

@Strubbl
Copy link
Contributor

Strubbl commented Jan 17, 2022

There are two file upload limits. There is a file upload limit by your webserver and by pixelfed itself.

@cloo
Copy link
Author

cloo commented Jan 17, 2022

It makes no sense to tell the user how many limits there are. User must only know how big files he can actually upload, so he would not have bad experience. Also user must be able understand why the error is shown.
At first I thought it was a defective system: firstly because it said so, and secondly because it is so common to warn about too big files.

@Strubbl
Copy link
Contributor

Strubbl commented Jan 17, 2022

Was a hint for the developers to check both values not only one.

@dansup dansup closed this as completed in 879281c Jan 23, 2022
@dansup
Copy link
Member

dansup commented Jan 23, 2022

@cloo Fixed in the latest commits!
Screen Shot 2022-01-22 at 9 20 00 PM

@Strubbl Good point, will add a warning to the admin dashboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants