Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Invalid type case in media_attachments #3281

Closed
4 tasks done
dansup opened this issue Mar 2, 2022 · 0 comments
Closed
4 tasks done

[API] Invalid type case in media_attachments #3281

dansup opened this issue Mar 2, 2022 · 0 comments
Labels
🔃 API For accessing Pixelfed data 🐛 Bug Something isn't working 💼 WIP This is currently being worked on

Comments

@dansup
Copy link
Member

dansup commented Mar 2, 2022 •
edited

The value of this line should be wrapped in strtolower() to be compatible with Mastodon API.

pixelfed/app/Transformer/Api/MediaTransformer.php

Line 14 in f8616c5

'type' => $media->activityVerb(),

Todo:

  • Add strtolower()
  • Update any Image or Video comparison logic
  • Bump media cache version to invalidate old attachments
  • Update changelog
@dansup dansup added 🐛 Bug Something isn't working 🔃 API For accessing Pixelfed data 💼 WIP This is currently being worked on labels Mar 2, 2022
@dansup dansup mentioned this issue Mar 2, 2022
Closed
@dansup dansup closed this as completed in c166925 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔃 API For accessing Pixelfed data 🐛 Bug Something isn't working 💼 WIP This is currently being worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dansup