Visual Indication For Favourites

[BrainBlasted]

Currently when you favourite an image, the heart stays the same color. Since a common pattern is to change the color of already favourited entities in other platforms, I was confused and did a brief like-unlike loop. Perhaps the color could be changed to black when something is already favourited?

[trwnh]

Seems to be live, albeit with a bug where already-liked posts are unfilled and stuck in reverse of what they should be.

[trwnh]

Also not indicating on individual posts - only on timeline.

[dansup]

Fixed in #186 #187 #188

[BrainBlasted]

@dansup can you reopen this issue? Currently the favourites button no longer changes colors.

[BrainBlasted]

Aplogies, must have been something on my end.

[BrainBlasted]

Ah, figured it out. The button is not the proper color if you reload with the image already favourited. Hitting the favourite button again may unfavourite it.

[trwnh]

@BrainBlasted The current solution to that right now is to run ls.clear() in your browser's console, because the cause of the issue is the hydration of likes. Anything you liked before the indicator logic was implemented seems to be reversed as you described.

This will be less and less of an issue for new users, but I have to think that hydrating likes shouldn't cause any issues, and the indicators should be updated at the same time, but idk how all that works.

[dansup]

Fixed in latest commits!