Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashtag status\post count out by one #1485

Closed
jk-na opened this issue Jul 9, 2019 · 6 comments
Closed

Hashtag status\post count out by one #1485

jk-na opened this issue Jul 9, 2019 · 6 comments
Labels
🧠 Backend Related to server logic and execution 🐛 Bug Something isn't working 💼 WIP This is currently being worked on

Comments

@jk-na
Copy link

jk-na commented Jul 9, 2019

It seems that the most recent post for a particular hashtag on my instance is not being displayed in the hashtag view but is included in the post count within this view. This is the same whether navigating via the hashtag on a post, via a hashtag search or via the hashtag tab in the admin panel.

On my small instance I have a number of hashtags which have only thus far been used on one post, when I search for these or check the hashtag admin tab they are listed as having 1 post associated but when clicking on the hashtag view there are no photos displayed. In this case the post count on the hashtag view page says '0 posts' even though there is 1, the admin panel displays 1 status.

Similarly, I have some more regularly used hashtags which appear to display 1 less image than the post counts suggest should be displayed. The post count indicator in this case is correct, it just appears that one of the images is not being displayed and as it happens on all 1 post hashtags. Having checked through my timeline for a few of the hashtags I've confirmed that in my case it is the most recent post that isn't included.

So to summarise, single use hashtags display 0 photos, and the post count is 1 less (zero) than the actual hashtag count.
Hashtags used more than once are missing the most recent 1x post in hashtags views but the count is accurate.

STACK:
Pixelfed: 0.9.5
Postgres: 10.9
PHP: 7.2.17
Laravel: 5.8.24

Screenshot from 2019-07-09 08-34-24
Screenshot from 2019-07-09 08-36-26
Screenshot from 2019-07-09 08-37-02
Screenshot from 2019-07-09 08-37-26

@jk-na
Copy link
Author

jk-na commented Jul 9, 2019

Seems like this might be in some way similar to the previous issue I raised: #1359

@dansup
Copy link
Member

dansup commented Jul 9, 2019

@jk-na The count includes private/unlisted posts (not displayed) and comments containing that hashtag (not displayed).

@jk-na
Copy link
Author

jk-na commented Jul 9, 2019

@jk-na The count includes private/unlisted posts (not displayed) and comments containing that hashtag (not displayed).

OK, but all of my posts are public and there are no comments containing hashtags in any of them.

@okpierre
Copy link
Contributor

@jk-na The count includes private/unlisted posts (not displayed) and comments containing that hashtag (not displayed).

@dansup can I suggest to exclude private/unlisted/not displayed to avoid confusion and for a better experience?

@raphgilles
Copy link

I have exactly the same issue.

@dansup dansup added 🐛 Bug Something isn't working 💼 WIP This is currently being worked on 🧠 Backend Related to server logic and execution labels Jul 10, 2019
@okpierre
Copy link
Contributor

okpierre commented Jul 10, 2019

Confirming issue exists with today's commit

@dansup dansup closed this as completed in 4ca415e Jul 11, 2019
hnrd pushed a commit to hnrd/pixelfed that referenced this issue Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧠 Backend Related to server logic and execution 🐛 Bug Something isn't working 💼 WIP This is currently being worked on
Projects
None yet
Development

No branches or pull requests

4 participants