Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming for TXT files #107

Open
irigone opened this issue Jan 9, 2021 · 2 comments
Open

Better naming for TXT files #107

irigone opened this issue Jan 9, 2021 · 2 comments

Comments

@irigone
Copy link

irigone commented Jan 9, 2021

Currently, txt files have the model ID as their name. Maybe it's better if they have the keyboard name in the file name, too? Some people have 2 keyboards, having files with distinguishable name such as "655491117GK61 RGB.txt" would be far better in my opinion.

@pixeltris
Copy link
Owner

To not be a breaking change this would need to be optional i.e. support both 655491117.txt and 655491117-GK61 RGB.txt. Code like the following would need to be changed to check multiple paths:

UserDataFile userData = UserDataFile.Load(device.State, GetUserDataFile(device));

@Jonavin
Copy link
Contributor

Jonavin commented Feb 26, 2021

I forked a copy to play with it. I added command line args for gui mode and a filename option and prefix. This way I can play with multiple files for the same device at the same time. It was easier to do rollbacks this way. This seems to work pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants