Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitization for video-swap-new-ublock-origin.js & vaft-ublock-origin.js #232

Open
ryanbr opened this issue Mar 26, 2024 · 1 comment
Open

Comments

@ryanbr
Copy link

ryanbr commented Mar 26, 2024

Wanting to merge the uBO scripts into Brave. brave/adblock-resources#160

Some sanitization issues on the script, is something can be addressed upstream? Or safe to ignore?

@pixeltris
Copy link
Owner

It doesn't look like anything too crazy to me. If you want to fix them up PRs are welcome but I'm unlikely to do that myself.

FYI I don't know how Brave's script injection works but there's some issue with the scripts randomly not getting injected with userResourcesLocation. Might be worth looking at #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants