Quick bar loses selection

[twschiller]

Steps to reproduce (to verify)

• Select text
• Hit Quick Bar short cut
• Select text passed to the extension is blank

Possible causes:

• If PixieBrix does not already have access to the page, it can't track the selection prior to hitting the keyboard shortcut. Hitting Cmd+K my unselect the text before PixieBrix has a chance to find the selection

cc @MMirandi - I think you were seeing this?

[fregante]

The logic to preserve the selection is managed by KBarToggle:

pixiebrix-extension/src/components/quickBar/QuickBarApp.tsx

Line 60 in fd14c10

selection.save();

Does/should useAutoShow also trigger that?

pixiebrix-extension/src/components/quickBar/QuickBarApp.tsx

Lines 100 to 105 in fd14c10

	function useAutoShow(): void {
	const { query } = useKBar();
	useEventListener(QUICKBAR_EVENT_NAME, () => {
	query.toggle();
	});

[twschiller]

Good catch, @fregante. I think that's worth a try. If that's the case, the buggy behavior should occur reliably on pages that PixieBrix does not have access to until the user toggles the KBar with the keyboard shortcut

[fregante]

I can't replicate the issue:

Screen.Recording.3.mov

You can see that the content script doesn't load until I press cmd-k because that's when the (unrelated) "Action" button appears.

However I'm seeing some strange behavior when the editor is open:

• the extension doesn't appear in the dropdown
• the quickbar does not open later (cmd-k, esc, cmd-k)

Screen.Recording.5.mov

The logic to preserve the selection is managed by KBarToggle:

I checked now: The selection controller is called even by the auto show.

The only incorrect behavior is that it always calls restore when the content script is loaded, because showing === false. That's not a problem though, because it exits immediately with a noop in that case:

pixiebrix-extension/src/utils/selectionController.ts

Lines 58 to 61 in fd14c10

	restore(): void {
	if (!selectionOverride) {
	return;
	}

[fregante]

It's somewhat possible that this is entirely caused by

• The content script is injected twice (editor open, click browser action) #3510

The selection is saved into memory so if the second selection.save() call happens when the selection is moved, then the restoration will also not work. But then again I can't replicate it.

[fregante]

Closing as resolved as this was likely a consequence of multiple kbar injections. Reopen if needed