Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught library edge/corner cases crash the client unnecessarily #24

Closed
edev opened this issue Feb 28, 2019 · 1 comment
Closed

Uncaught library edge/corner cases crash the client unnecessarily #24

edev opened this issue Feb 28, 2019 · 1 comment

Comments

@edev
Copy link
Collaborator

edev commented Feb 28, 2019

As far as we know, the pysftp library remains in a valid state any time it encounters an error. We catch and print errors in the controller, but we then close the application, which can be inconvenient. Wouldn't it be preferable to catch exceptions, print them, and then continue?

If we want to be a bit more cautious, we could specifically catch OSError (which is a synonym of IOError) and possibly one or two other, specific error classes that we know our libraries can raise, and we can continue execution after printing the error messages. However, if we receive any other types of exceptions, we can print and exit.

@pixieofhugs
Copy link
Owner

It sounds like usability sugar like, it's nice to have but not the biggest deal? work on it if you want/there is nothing pressing. It's a priority 3 with 0 being the highest priority

"wouldn't it be preferable" != "oh god it's all going to die"

@edev edev closed this as completed Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants