Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] The Demo uses separate filters-files when build:dev #89

Closed
finscn opened this issue Oct 25, 2017 · 5 comments
Closed

[REQUEST] The Demo uses separate filters-files when build:dev #89

finscn opened this issue Oct 25, 2017 · 5 comments

Comments

@finscn
Copy link
Contributor

finscn commented Oct 25, 2017

The Demo is not only for demo , it's also a very good test case.
I think many developers would use it for testing when the filter is under develop.
But the new Demo is hard to test and dev.

When add or modify the filters-files , users have to run npm run build again.

I think uses separate filters-files is a better choice.

Thank you.

@bigtimebuddy
Copy link
Member

A better way to develop is by using “npm run watch” so you don’t have to rebuild every time.

@finscn
Copy link
Contributor Author

finscn commented Oct 25, 2017

I've tried.
but after I changed & saved the files of filters , reload the demo/index.html , there is no new result.

@finscn
Copy link
Contributor Author

finscn commented Oct 26, 2017

I found the watch script doesn't rebuild the files for demo.

@bigtimebuddy
Copy link
Member

Will look into it

@bigtimebuddy
Copy link
Member

This has been fixed since I made all filters use the top-level package. You need to npm run watch from the root level. In another terminal instance cd to tools/demo and also run npm run watch there. This should allow you to change filters and change the demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants