Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting frequency < 0 could crash page #12

Closed
lselden opened this issue Sep 14, 2015 · 1 comment
Closed

setting frequency < 0 could crash page #12

lselden opened this issue Sep 14, 2015 · 1 comment

Comments

@lselden
Copy link

lselden commented Sep 14, 2015

If you set the spawn frequency to an invalid number ( < 0, and possibly a NaN ) then the update loop could end up crashing the page. Perhaps there needs to be a sanity check (custom setter?) on frequency to enforce 0 if NaN or < 0?

@andrewstart
Copy link
Contributor

The frequency actually needs to be > 0, because a value of 0 would still cause an infinite loop. That said, good catch, I've fixed this in release 1.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants