Fixes the padding for Graphics #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtimebuddy
added
Plugin: Graphics
🕷 Bug
|
Looks like this was changed here #2729 when width and height were calculated instead of maxX and maxY |
themoonrat
approved these changes
May 14, 2017
ivanpopelyshev
approved these changes
May 15, 2017
ivanpopelyshev
added a commit
that referenced
this pull request
Oct 23, 2017
* Fix destroyed textures throwing errors when destroyed again. (#3931) * Fixes issue with addOnce on ticker (#3938) * Fix not respecting target of mouseup events. (#3940) * Fix not respecting target of mouseup events. * Fix #3199 by honoring alpha (#3943) * fix #3199 by honoring alpha * use old algorithm for noise color adjustment * add ctor args for uniforms * Add jsdocs for ctor args * Fixed if statement checks that do not work if the stop point is set to 0 (#3948) * Remove enumeration from deprecations (#3952) * Fixes priority adding of ticker listeners (#3958) * fix(GraphicsRenderer): fix graphics render with fill and line when na… (#3945) * fix(GraphicsRenderer): fix graphics render with fill and line when nativeLines=true * fix(GraphicsRenderer): fix eslint and jsdoc * Fixes #3954 support excluding deprecations (#3959) * Fixes #3954 support excluding deprecations * Resolves linting issue * Stops TickListener 'this.fn is not a function' error (#3956) Fixes: #3936 * fix #3252, add an interpolation value for the color matrix result * Renames interpolation to alpha * 4.5.1 * Removes deprecation warnings with TextMetrics usage (#3969) * Removes deprecation warnings with TextMetrics usage * Removes unnecessary if-check, since this is handled by measureFont * Removed unit test for deprecated Texture cache functions (#3970) * Make Interaction events closer to Browser behavior (#3963) * Added normalized pointer data to InteractionData. * Use touch events for touches, not pointer events. * Emit mouse events for pen pointer events. Also cleaned up pointer type and mouse button detection. * Removes Bower mention from README (#3980) * Removes Bower mention from README * Removes Bower link * Adds note about Bower * Test script (#3984) * npm test run out-of-the-box * Renames test command build to dist * Renames tests to unit-tests * modularized removeItems #3939 (#3977) * Added a fallback for cursor modes without styles (#3975) * Added a fallback for cursor modes without styles * Added unit test. * return of TextureTransform (#3989) * critical fix 3987, 3986 (#3991) * TilingSprite destroy fix (#3995) * TilingSprite destroy fix * animationSprite too! * fix for #3972 (#3985) * Modifies the cached tinted frame of a texture in canvas * removed the document append line.. oops * Missing lint from travis test (#3998) * Missing lint from travis test * Remove "only" blocking other tests * Take into account baseTexture resolution when registering a BitmapText. (#3993) * take into account baseTexture resolution when registering a BitmapText. * PIXI.settings.RESOLUTION instead of 1 * change settings reference * explicit operator order * added parenthesis. no mixed operators issue * Add `updateTexture` & some shortcuts in Sprite; Cosmetic (#4000) * Add `updateText` and some shortcuts for texture * Add `updateText`. If a sprite is create by a canvas , when the canvas's changed , user could call `updateText` for updating sprite. * Add some shortcuts for accessing some properties of sprite._texture. * Cosmetic, for DRY Just define some local vars for accessing properties of `this` , for DRY. * remove the changing of Sprite * Apply Tint to Particle Container (#3899) (#4014) * Apply Tint to Particle Container (#3899) * Apply Tint to Particle Container (#3899), added _tintRGB property * Apply Tint to Particle Container (#3899), added comment regarding webGL support only * fix changing textures to a 1 frame animation bug (#4011) * Fixes the padding for Graphics (#4020) * Fixes Loader overriding destroy with removeView arg (#4018) * fix(Graphics): exclude holes in Graphics#containsPoint (#3976) * fix(GraphicsRenderer): fix graphics render with fill and line when nativeLines=true * fix(GraphicsRenderer): fix eslint and jsdoc * fix(Graphics): exclude holes in Graphics#containsPoint * Adds unit-test for graphic hole (#4030) * Fix context restore. (#4031) * 4.5.2 * fix for issue #4043: CORS not working with PIXI.Sprite.fromImage (#4050) * gl.SCISSOR_TEST fix (related to #4004) (#4052) * premultiply blendModes, critical for compressed textures. (#4033) * premultiply blendModes, critical for compressed textures. * sprite renderer batch blendmode fix * derp fix * move some stuff to table * fix default export * derp * ternary and fix * DERP! tintRgb now without _, its a legal property (#4058) * TilingSprite derp (#4060) * Text drop shadow is now the right colour, even with blur enabled (#4069) Fixes: #3960 * Fixes clear error on CanvasRenderer with no child container (#4065) * Fixes clear error on CanvasRenderer with no child container #4045 * Unit tests to check that .clear() can be called on a freshly created renderer with no containers added * Wrapped WebGL test in withGL * deprecation.js now works with modules excluded at build time (#4067) Fixes: #3710 * Record how many spaces have already been removed when resetting the index for a new line of text after hitting the maxWidth limit (#4064) Fixes #4063 * Changed BitmapText max width to be a setter (#4068) * Changed BitmapText max width to be a setter Fixes: #3853 * Noticed that maxLineHeight was exposed, but setting it never effected anything. So made private and just put a readonly getter * fix negative width/height of rectangle (#4074) * Changes the default dropShadowColor in TextStyle (#4083) * Adds an onLoop callback for AnimatedSprites (#4080) * Adds an onLoop callback for AnimatedSprites * everyone lovesa trailing space * doc fix for renderer.bindTexture (#4084) * Update LICENSE * Update LICENSE * Fix Sprite.containsPoint edge handling (#4092) * Fix Sprite.containsPoint edge handling * Fix TilingSprite.containsPoint edge handling * Cleaning the code (#4086) * remove property assignment from destructor * premultiplyAlpha is for GLTexture premultipliedAlpha is for BaseTexture * more fixes * line too long * Added missing docs for Renderer options (#4098) * Added missing docs for Renderer options * Fixed line order * Fixed typos * Fixes typos * 4.5.3 * Remove duplicated base url from loader path in the bitmapFontParser (#4101) * Remove release branch pushes upon publish (#4099) * Update index.js (#4120) Expose InteractionTrackingData and InteractionEvent through PIXI.interaction * fix ColorMatrixFilter.prototype.contrast (#4130) * update to latest resource-loader (v2.0.9) * Standardizes how name is represented globally (#4132) * Standardizes how pixi is represented as a name, adds missing meta jsdoc fields * Replaces more missing instances * Missing package.json description * Fixes contributing with brand * Cleanup the repository mentions in contributing doc * Includes the sum in the error thrown when trying to create a texture (#4159) * Includes the sum in the error thrown when trying to create a texture from a base using an invalid rectangle * Casts quantities to type number in Rectangle constructor * fix tilingSprite alpha tint (#4165) * Two small grammar fixes (#4172) * Fix typo in ParticleContainer.js * Fix grammar in AnimatedSprite.js * Fixed issues with overlapping shapes in masks for WebGL (#4164) #2559 #2877 * _glRenderTargets destroyed when RenderTexture destroyed (#4173) * make blendMode a property with documentation, pass it to inner filter (#4131) * Fixes destroyTexture method on TextureManager (#4174) * 4.5.4 * I dont know if its a crit. (#4176) * Adds improvements to README, fixes broken links (#4185) * Graphics drawPolygon: (#4191) * update documentation -- method also accepts a PIXI.Polygon * Fixed an issue in CanvasRenderer where globalCompositeOperation is being changed without _activeBlendMode being updated. (#4195) * There's no resources page in wiki. (#4184) * leading support (#4194) * Update TextMetrics.js * Update TextStyle.js * Before deleting texture from cache, check that it's the same one passed into removeFromCache (#4198) * Adds docs for TextStyle getters and setters (#4199) #4197 * Add autoStart option to PIXI.Application (#4208) autoStart option allows users to configure the ticker before starting the rendering. That helps to synchronize audio and to control ticker for asynchronous recording using this.ticker.update. * Set initial lastTime to -1 (#4209) update method could have 0 as timestamp, but the frame would be ignored because the initial lastTime is 0. Let it have a negative value. * Add option for dual-graphics devices (#4119) * initial commit * docs * webgl-only * one space * Add Google Analytics to Documentation (#4215) * Add Google Analytics to docs * Updated year on the license * Pins jsdoc to 3.4.3 (#4232) * Fixed nested stenicl masks not rendering correctly (#4211) * Fixed nested stencil masks not rendering correctly. * Fixed jslint errors. * Documented the changes. * 4.5.5 * Tiling texture works on canvas when replacing textures (#4269) * refactor, remove unnecessary operations (#4257) * Improving SVG handling in Spritesheets with sourceScale support (#4271) * fix 3926 (#4275) * Use local variable for `uniformData[i].type.toLowerCase()` (#4277) * filters can survive context loss (#4285) * filters can survive context loss * falsifying. * Fix texture's frame dimension error report (#4281) * Fix frame dimension error report * Add relation operator * Fix lint * move toLowerCase() into constructor (#4284) * tint in ParticleContainer (#4289) * tint:false does not work yet! * The static bug is fixed. * xerver changes * fixing dirty problem in plane/nineslice (#4299) * particle container docs and resize mode (#4295) * particle container docs and resize mode * DERP * just a doc * fix canvas sprite texture change (#4303) * fix canvas sprite texture change * found it! * TilingSprite tint fix * clean tilingsprite * Switch jsdoc theme to pixi-jsdoc-template (#4311) * 4.5.6 * context save and restore (#4332) * Video base texture cross origin (#4345) * Ported cross origin code from the fromImage function in BaseTexture to fromUrl in VideoBaseTexture Fixes #4007 * Latest cross-origin code from BaseTexture copied to VideoBaseTexture * reduced duplication of cross origin code * fix NineSlice with resolution (#4309) * Force base render textures to be whole pixels to fix error in IE (#4316) https://jsfiddle.net/themoonrat/71hadj49/ * Add textures in reset method (#4344) * textures in reset * active vao in reset * Add AlphaFilter, deprecate VoidFilter (#4349) * Add AlphaFilter, deprecate VoidFilter * better docs * shorter initialization * dirty as in Rope (#4354) * Add default value of `mesh.texture` (#4355) More talking about this PR : #4352 * bitmapfont: backward compatibility + tests (#4362) * bitmapfont_registration: refactor + tests * issue_4213_bitmapfont_regisration: visual test removed * rename GroupD8.isVertical (#4363) * rename very hard name to GroupD8.isVertical * jsdoc on deprecation * Fixes bug in InteractionManager-test mentioned in issue #4365 (#4366) * Feature to support trimmed Textures as masks (#4357) * Texture region as a mask * let it bleed a bit * I've made it better! Everything else goes into separate PR. * DERP * RE-DERP * docs and mesh crash on empty texture * last fixes * Re-adds fix for bitmap font test
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4019
Broken : https://jsfiddle.net/ed6zpLtj/
Fixed: https://jsfiddle.net/frzjy4vx/