Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource-loader version #4570

Merged
merged 1 commit into from Jan 3, 2018
Merged

Update resource-loader version #4570

merged 1 commit into from Jan 3, 2018

Conversation

englercj
Copy link
Member

@englercj englercj commented Jan 1, 2018

Updated resource-loader from v2.0.9 to v2.1.1.

Most important changes are to fix englercj/resource-loader#102 and englercj/resource-loader#106.

Full change logs: v2.1.0, v2.1.1.

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 2.1.1 is not available on NPM. Are you sure you published?

$ npm info resource-loader dist-tags
{ latest: '2.0.9' }

@englercj
Copy link
Member Author

englercj commented Jan 3, 2018

My bad, published now.

$ npm info resource-loader dist-tags
{ latest: '2.1.1' }

I restarted the travis build.

@bigtimebuddy bigtimebuddy added Difficulty: Easy 🕷 Bug Verified that it’s actually a legit bug that exists in the current release. 🙏 Feature Request Community request for new features, APIs, packages. 💾 v4.x (Legacy) Legacy version 4 support labels Jan 3, 2018
Copy link
Contributor

@andrewstart andrewstart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please! (one of my coworkers had recently wanted to make a change from v2.1.1, then discovered someone already made it)

@bigtimebuddy bigtimebuddy merged commit cba512d into pixijs:dev Jan 3, 2018
bigtimebuddy pushed a commit that referenced this pull request Jan 3, 2018
@lock
Copy link

lock bot commented Feb 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕷 Bug Verified that it’s actually a legit bug that exists in the current release. 🙏 Feature Request Community request for new features, APIs, packages. 💾 v4.x (Legacy) Legacy version 4 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants