Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blendModes with NineSlicePlane and CanvasRenderer #4603

Merged
merged 2 commits into from Jan 12, 2018

Conversation

ivanpopelyshev
Copy link
Collaborator

@ivanpopelyshev ivanpopelyshev commented Jan 12, 2018

That's from Mesh:

renderer.context.globalAlpha = mesh.worldAlpha;
renderer.setBlendMode(mesh.blendMode);

blendMode line is missing in NineSlicePlane. I can be a problem if something sets not-normal blendmode before NineSlicePlane is rendered.

Previously in Canvas Mesh: #4535

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Verified

Broken (current dev):
https://jsfiddle.net/e60yhvex/

Fixed (this PR):
https://jsfiddle.net/0kt7gLyn/

Intended Result
screen shot 2018-01-12 at 9 00 33 am

@ivanpopelyshev
Copy link
Collaborator Author

Good, I just want to mention that usually people dont use anything except Normal on NineSlice, but they can use different blendMode in the element that appears before Plane

@bigtimebuddy bigtimebuddy added 🕷 Bug Verified that it’s actually a legit bug that exists in the current release. Priority: Medium 💾 v4.x (Legacy) Legacy version 4 support labels Jan 12, 2018
@bigtimebuddy bigtimebuddy changed the title NineSlicePlane blending Support blendModes with NineSlicePlane and CanvasRenderer Jan 12, 2018
@lock
Copy link

lock bot commented Feb 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕷 Bug Verified that it’s actually a legit bug that exists in the current release. 💾 v4.x (Legacy) Legacy version 4 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants