Add unit tests for Application.ticker setter

[schipiga]

Hello folks! I like autotests and would like to start to contribute to your project

[bigtimebuddy]

Thanks for being willing to help. Definitely could use some help with writing more tests! Glad you're eager to help. Let me know if you'd like to join the PixiJS Slack.

As for this PR, couple of things:

• Please remove the use of the fat-arrow => with Mocha, it actually loses the global context, which we'd like to retain for handling variables and other useful bits (like setting timeouts, slow, etc). As a practice, we keep that in using function.
• Not sure beforeEach is a good choice here. Even though that the autoStart test is the exception, in the future creating with a variety of constructor options is desirable. Would get messy with beforeEach.
• I would just add a before in your describe and set this.app = new PIXI.Application(), then reference this.app in your ticker tests. Make sure to destroy it with after.

[schipiga]

hi @bigtimebuddy, thank you for code review. I will fix it later. Yeah, I would like to join to pixijs slack

[bigtimebuddy]

Just send me your email address: matt@mattkarl.com

[schipiga]

Hi @bigtimebuddy,

Could you please review it again. I seem, I also fix typo, that destroy didn't consider that ticker may not be, but set ticker gives such ability.

[bigtimebuddy]

Looking much better. One small change can you remove self and just use this within your tests. Means the same thing. No need to cache this

[schipiga]

@bigtimebuddy
in this case I will use it('<test name>', () => instead of it('<test name>', function (), in order to use this inside a test. Is it ok? As I remember, you wrote:

Please remove the use of the fat-arrow => with Mocha, it actually loses the global context, which we'd like to retain for handling variables and other useful bits (like setting timeouts, slow, etc). As a practice, we keep that in using function.

[bigtimebuddy]

Actually in Mocha it’s all the same context, whether inside it, or containing describe.

[schipiga]

ok, cool! didn't know, thank you, fixed it

[schipiga]

@bigtimebuddy , could you please review again. As I believe, I fixed all

[bigtimebuddy]

Nice one, thanks @schipiga.

And good first PixiJS PR!

[schipiga]

thank you :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.