Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Reorganized mesh classes #4963

Merged
merged 2 commits into from Jun 10, 2018
Merged

[next] Reorganized mesh classes #4963

merged 2 commits into from Jun 10, 2018

Conversation

bigtimebuddy
Copy link
Member

Overview

This change externalizes the PIXI.Mesh (previously RawMesh) class so that it can be repurposed by the future GraphicsGeometry class. This class is generalized and does not belong with the other mesh class. The other Mesh-like classes moved to a new package @pixi/mesh-extras

Changed

  • Adds new @pix/mesh-extras package which contains NineSlicePlane, Plane, Rope and Mesh2d
  • Renames PIXI.Mesh -> PIXI.Mesh2d
  • Renamed PIXI.RawMesh -> PIXI.Mesh

@bigtimebuddy bigtimebuddy changed the title Reorganized mesh classes [next] Reorganized mesh classes Jun 10, 2018
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! Nice work dude!

@bigtimebuddy bigtimebuddy merged commit b2f65b4 into next Jun 10, 2018
@bigtimebuddy bigtimebuddy deleted the next-mesh-reorg branch June 10, 2018 20:04
@lock
Copy link

lock bot commented Jun 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants