Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispose framebuffer like in v4 #5387

Merged
merged 4 commits into from Jan 27, 2019
Merged

dispose framebuffer like in v4 #5387

merged 4 commits into from Jan 27, 2019

Conversation

ivanpopelyshev
Copy link
Collaborator

@ivanpopelyshev ivanpopelyshev commented Jan 26, 2019

Fiddle from #5328 , check that shift+escape in chrome dont give you 1 extra gig in GPU memory.

https://jsfiddle.net/Hackerham/1bdoyra8/5/

If you try it on current dev , it will probably crash WebGL context.

@ivanpopelyshev ivanpopelyshev added 🕷 Bug Verified that it’s actually a legit bug that exists in the current release. 🔥 High Priority These are PRs or issues that are extremely important to address either because they are from sponsor Version: v5.x labels Jan 26, 2019
@ivanpopelyshev ivanpopelyshev added Type: Enhancement and removed 🕷 Bug Verified that it’s actually a legit bug that exists in the current release. labels Jan 26, 2019
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @ivanpopelyshev 👍

@bigtimebuddy bigtimebuddy merged commit 33c73cc into dev Jan 27, 2019
@bigtimebuddy bigtimebuddy deleted the dev-framebuffer-dispose branch January 27, 2019 21:28
@lock
Copy link

lock bot commented Jan 27, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔥 High Priority These are PRs or issues that are extremely important to address either because they are from sponsor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants