Fixes emoji characters not displaying when letterSpacing style is used

[themoonrat]

Description of change

#5571
Changed fix to use Array.from as linting didn't like the use of for each over a string

Pre-Merge Checklist

• Documentation is changed or added
• Lint process passed (npm run lint)
• Tests passed (npm run test)

[bigtimebuddy]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from

Array.from is not supported in IE, need a polyfill in the polyfills package.

[themoonrat]

Ahhhh sorry! I forget we're only in a semi es6 world.

[themoonrat]

So, I've tweaked it so that it only uses Array.from if it exists.
There is no use polyfilling it, as it will still display incorrectly in IE; it requires the iterable powers of es6 that that just can't be polyfilled from my research.
It's also not perfect at splitting emoji; 👩‍❤️‍💋‍👩 will get split into 👩❤💋👩.
To get it all perfect would required a big 100kb library like https://github.com/orling/grapheme-splitter which we're not going to be adding into PixiJS.

But at least in most scenarios things are better with this PR. They're never worse, anyway!

[bigtimebuddy]

I'm okay with this 👍

[GoodBoyDigital]

nice fix 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.