FilterSystem: remove division that can cause problems #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpopelyshev
added
🛸 X-Files
bigtimebuddy
approved these changes
May 20, 2019
GoodBoyDigital
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally I found the case where our
x / resolution * resolution > xproblem can wreck everything.In my client's case filter has resolution param that can be add some blur to the filter using cheap method. If the texture is reated first time, it can force a wrong FrameBuffer size.
The method in quesion is
getFilterTexture(resolution), but for demo I just change global constant, its the same really.I'm sure there are other cases like this, I will make full investigation later and we'll find a better fix. However this PR also makes code easier, that's why I suggest to merge it.
Previously we discussed that problem in #4745
Demo: https://www.pixiplayground.com/#/edit/GzB3lpQ91nFdY8zYyuQE4
Fixed: https://www.pixiplayground.com/#/edit/jfgheFVU2ELNe_Y52hKRQ