Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Graphics holes with CanvasRenderer #5734

Merged
merged 2 commits into from
May 29, 2019

Conversation

ivanpopelyshev
Copy link
Collaborator

@ivanpopelyshev ivanpopelyshev commented May 28, 2019

Fix #5727

Its partial fix that works only for polygon that has polygon holes. drawRect and other things wont work with it.

Bug: https://www.pixiplayground.com/#/edit/4GVTR9VA2uBmxe74PB2~z
Fixed: https://www.pixiplayground.com/#/edit/VJga6DVoy9jekGt1e~NzF

get shape points in canvas
Copy link

@rpatwariingenuity rpatwariingenuity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for Canvas. Use moveTo and lineTo.

@bigtimebuddy bigtimebuddy added this to the v5.0.4 milestone May 28, 2019
@bigtimebuddy bigtimebuddy changed the title Fix canvas polygon holes Fixes Graphics holes with CanvasRenderer May 29, 2019
@bigtimebuddy bigtimebuddy merged commit 6e06774 into dev May 29, 2019
@bigtimebuddy bigtimebuddy deleted the dev-graphics-canvas-polygon-hole branch May 29, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holes don't work in CanvasRenderer
4 participants