Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSDoc comments on the TextureUvs properties #5828

Merged
merged 1 commit into from Jun 25, 2019

Conversation

mofnire
Copy link
Contributor

@mofnire mofnire commented Jun 25, 2019

Description of change

The PIXI.TextureUvs properties such as x0 are missing in the type declaration file. I thought this might be intentional. If so, I'm sorry for bothering you :(. However, they were in the PixiJS v4 type declaration file. So I thought this might be not. This PR adds JSDoc comments on the TextureUvs properties.

I omit the property TextureUvs#uvsFloat32 on purpose.
It looks too internal to me.

Pre-Merge Checklist
  • Documentation is changed or added
  • Lint process passed (npm run lint)

@codecov-io
Copy link

Codecov Report

Merging #5828 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5828   +/-   ##
=======================================
  Coverage   70.57%   70.57%           
=======================================
  Files         205      205           
  Lines       10396    10396           
=======================================
  Hits         7337     7337           
  Misses       3059     3059
Impacted Files Coverage Δ
packages/core/src/textures/TextureUvs.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccdfa1e...eb9be82. Read the comment docs.

@bigtimebuddy bigtimebuddy merged commit e4749be into pixijs:dev Jun 25, 2019
@mofnire mofnire deleted the dev-texture-uvs-type-declaration branch June 27, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants