Fixes the prepare system in v5 #5834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 errors here; the first is in Prepare.js, the property on the renderer was renamed in v5 from textureManager to texture. (added a deprecation for this) Second, the TextureSystem had an assumption in updateTexture that there would be a glTexture, which could end up throwing an error
Codecov Report
@@ Coverage Diff @@
## dev #5834 +/- ##
==========================================
- Coverage 70.56% 70.56% -0.01%
==========================================
Files 205 205
Lines 10396 10398 +2
==========================================
+ Hits 7336 7337 +1
- Misses 3060 3061 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #5834 +/- ##
==========================================
- Coverage 70.56% 70.56% -0.01%
==========================================
Files 205 205
Lines 10396 10398 +2
==========================================
+ Hits 7336 7337 +1
- Misses 3060 3061 +1
Continue to review full report at Codecov.
|
andrewstart
approved these changes
Jun 25, 2019
bigtimebuddy
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 errors here; the first is in Prepare.js, the property on the renderer was renamed in v5 from textureManager to texture. (added a deprecation for this)
Second, the TextureSystem had an assumption in updateTexture that there would be a glTexture, which could end up throwing an error