Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch renderer types #5871

Merged
merged 2 commits into from Jul 3, 2019
Merged

Batch renderer types #5871

merged 2 commits into from Jul 3, 2019

Conversation

ivanpopelyshev
Copy link
Collaborator

@ivanpopelyshev ivanpopelyshev commented Jul 2, 2019

Can't build pixi-projection without it.

Those fields have to be overriden in constructor, cant do that in case of read-only.

Protected _shader is needed for extra renderer hacks.

Factory doesn't return BatchRenderer, it returns class of BatchRenderer.

@bigtimebuddy bigtimebuddy added this to the v5.1.0 milestone Jul 2, 2019
@codecov-io
Copy link

codecov-io commented Jul 3, 2019

Codecov Report

Merging #5871 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5871      +/-   ##
==========================================
+ Coverage   70.52%   70.53%   +<.01%     
==========================================
  Files         206      206              
  Lines       10407    10407              
==========================================
+ Hits         7340     7341       +1     
+ Misses       3067     3066       -1
Impacted Files Coverage Δ
packages/core/src/batch/BatchRenderer.js 30.72% <ø> (ø) ⬆️
packages/core/src/batch/BatchPluginFactory.js 84.61% <ø> (ø) ⬆️
packages/ticker/src/Ticker.js 88% <0%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac01a7...6b75a84. Read the comment docs.

@bigtimebuddy bigtimebuddy merged commit a208dac into dev Jul 3, 2019
@bigtimebuddy bigtimebuddy deleted the dev-fix-types branch July 3, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants