Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchBuffer.vertices => ViewableBuffer.rawBinaryData #5881

Merged
merged 1 commit into from Jul 4, 2019
Merged

Conversation

ShukantPal
Copy link
Member

@ShukantPal ShukantPal commented Jul 4, 2019

#5879 solved.

@codecov-io
Copy link

Codecov Report

Merging #5881 into dev will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5881   +/-   ##
=======================================
  Coverage   70.38%   70.38%           
=======================================
  Files         206      206           
  Lines       10454    10454           
=======================================
  Hits         7358     7358           
  Misses       3096     3096
Impacted Files Coverage Δ
packages/core/src/batch/BatchRenderer.js 30.38% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a67371...4199420. Read the comment docs.

@ivanpopelyshev
Copy link
Collaborator

ivanpopelyshev commented Jul 4, 2019

Oops!

Yes, it works: https://pixijs.io/examples/?v=refactor-dev#/demos-basic/container.js
Notice that i tested your branch by adding ?v there

@bigtimebuddy bigtimebuddy merged commit 8fb2882 into dev Jul 4, 2019
@bigtimebuddy bigtimebuddy deleted the refactor-dev branch July 4, 2019 20:13
@bigtimebuddy
Copy link
Member

Thank you for the quick PR @SukantPal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants