Fix lineStyle+fillStyle drawCalls count

[ivanpopelyshev]

lineStyle never goes into one drawCall with fillStyle if batching is turned off. That means PixiJS just spams drawCalls for graphics! Bug exists even in 5.0.1

Demo has extra feature: it shows wireframe for fills!

Bug, 2 drawcalls: https://www.pixiplayground.com/#/edit/oXRqFpfuva9wwP6B_0V1d

Fixed, 1 drawcall: https://www.pixiplayground.com/#/edit/AjVLQ2NLsXQXM9KrUWCcp

[bigtimebuddy]

This doesn’t make sense to me. Native is a line specific property. It doesn’t make sense to throw it on Fill. Are you sure you’re fixing the right thing here?

[ivanpopelyshev]

Oh, right, I didnt explain it, sorry :)

One big problem: https://github.com/pixijs/pixi.js/blob/dev/packages/graphics/src/GraphicsGeometry.js#L653
Not big, but adds extra batch: https://github.com/pixijs/pixi.js/blob/dev/packages/graphics/src/GraphicsGeometry.js#L484

false !== undefined.

[bigtimebuddy]

So fix that case. If native is undefined use false. Don’t change the API to something illogical.

[ivanpopelyshev]

OK then, do you want me to change those to != and comment "do not touch that" ?

[bigtimebuddy]

Just don't change LineStyle or FillStyle. It's not fixing the problem, it just creating API confusion.

For fills, can you just do !!style.native

[ivanpopelyshev]

ok, done

[codecov-io]

Codecov Report

Merging #5981 into dev will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##              dev    #5981   +/-   ##
=======================================
  Coverage   70.43%   70.43%           
=======================================
  Files         208      208           
  Lines       10516    10516           
=======================================
  Hits         7407     7407           
  Misses       3109     3109

Impacted Files	Coverage Δ
packages/graphics/src/GraphicsGeometry.js	73.12% <50%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3593e...ffa2b7e. Read the comment docs.

[eXponenta]

Thanks!
Now its works clean!

[bigtimebuddy]

Thanks, better!

[GoodBoyDigital]

coool 👍