fix for sync uniform group issue

[GoodBoyDigital]

Description of change

The introduction of syncData is to solves an issue where textures in uniform groups are not set correctly the texture count was always starting from 0 in each group. This needs to increment each time a texture is used no matter which group is being used.

Pre-Merge Checklist

• Documentation is changed or added
• Lint process passed (npm run lint)
• Tests passed (npm run test)

[ivanpopelyshev]

Trolling mode on: is there any way we can cover it with a test?

[bigtimebuddy]

I agree with Ivan. Unit test this if we can

[ivanpopelyshev]

if you make playground test, i'll make unit based on it.

[GoodBoyDigital]

cool! make an example 👍

[GoodBoyDigital]

here ya go dude!

busted:
https://www.pixiplayground.com/#/edit/lWhZH4Um86qUQRVteSg3C

working:
https://www.pixiplayground.com/#/edit/AVsYPqhNAgy586sN_SJFJ

[ivanpopelyshev]

Good test.

Uncaught ReferenceError: triangle2 is not defined

Im making a test based on it.

[ivanpopelyshev]

That's how its done. Basically, I copied parts of your playground and I check for boundTextures. It fails at current dev version.

[ivanpopelyshev]

Please remove package.lock changes.

[codecov-io]

Codecov Report

Merging #6217 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #6217      +/-   ##
==========================================
+ Coverage   76.71%   76.73%   +0.01%     
==========================================
  Files         202      202              
  Lines       10238    10238              
==========================================
+ Hits         7854     7856       +2     
+ Misses       2384     2382       -2

Impacted Files	Coverage Δ
packages/core/src/shader/ShaderSystem.js	93.58% <100%> (+0.16%)	⬆️
...ages/core/src/shader/utils/generateUniformsSync.js	86.2% <100%> (-0.89%)	⬇️
packages/core/src/shader/Shader.js	62.96% <0%> (+7.4%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bacd8c...fa5ac5e. Read the comment docs.

[GoodBoyDigital]

nice thanks man!