Fix graphics fillStyle instead of lineStyle #6226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpopelyshev
changed the title
ivanpopelyshev
changed the title
ivanpopelyshev
added
the
🕷 Bug
|
OK, its not fine, we have several copies of |
|
Should be fine now. |
Codecov Report
@@ Coverage Diff @@
## dev #6226 +/- ##
==========================================
+ Coverage 76.69% 76.71% +0.01%
==========================================
Files 202 202
Lines 10240 10238 -2
==========================================
Hits 7854 7854
+ Misses 2386 2384 -2
Continue to review full report at Codecov.
|
eXponenta
approved these changes
Nov 16, 2019
bigtimebuddy
approved these changes
Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another bug again, found by @eXponenta
Bugged: https://www.pixiplayground.com/#/edit/QF2RXuO21iDTwvxGntVBr
Fixed: https://www.pixiplayground.com/#/edit/yhKcbj73S9RHy1ajD0tdX
I've added test on it. With our previous tests everything should be fine, but I'll make a pass on pixijs examples anyway.
Also it fixes our typings.