Fix for when '_segmentsCount' can return NaN #6231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the moveTo y value and the quadraticCurveTo cpY and toY values are all the same, then
QuadraticUtils.curveLength
returns NaN, causingGRAPHICS_CURVES._segmentsCount
to return NaN.Demo: https://www.pixiplayground.com/#/edit/8jAg09k2W~L85zPt~ZfU_
Open up the console, put a breakpoint on
const n = GRAPHICS_CURVES._segmentsCount
and refresh the playground. Notice that 'n' will resolve to NaN.This is probably not the right solution for this, fixing the symptom rather than the cause, but just in case it's fine, here's the PR!