New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes roundPixels calculation differences between v4 and v5 #6234
Conversation
Added a PR using the PIXI.settings.RESOLUTION settings..... So help on a rethink of this is required please! :) |
Can you add this to Btw, we have separate |
I'm happy that you solved it for me. I didnt know what to do with that thing back then when I moved it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themoonrat could you possibly add a unit-test or two for this? It's a very subtle thing, but has some implications visually. Would be helpful to make sure we handle that case correctly in the future.
Codecov Report
@@ Coverage Diff @@
## dev #6234 +/- ##
==========================================
- Coverage 77.14% 77.13% -0.02%
==========================================
Files 203 203
Lines 10314 10316 +2
==========================================
Hits 7957 7957
- Misses 2357 2359 +2
Continue to review full report at Codecov.
|
@bigtimebuddy Sure, I'll have time on Friday to see if this can be unit tested in a meaningful way. Hopefully I can look in the vertex data to explain why putting 2 store sprites side by side does not work without this PR |
Thanks @themoonrat if you could add a unit-test PR later, that'd be great. |
Description of change
Fixes issue descripted in #6232 with roundPixels implementation difference between v4 and v5 for resolutions less than 1.
Pre-Merge Checklist
npm run lint
)npm run test
)