New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double onFrameChange events with AnimatedSprite #6274
Fix double onFrameChange events with AnimatedSprite #6274
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6274 +/- ##
==========================================
+ Coverage 76.75% 76.99% +0.23%
==========================================
Files 202 202
Lines 10245 10247 +2
==========================================
+ Hits 7864 7890 +26
+ Misses 2381 2357 -24
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent fix. Thanks for the tests.
Thank you! |
Guys, this thing fails on windows :( |
Tests or runtime fails @ivanpopelyshev? Can you be more specific? |
Description of change
if it's stoped naturally, then reset frame to the last frame and don't trigger one more onFrameChange
Pre-Merge Checklist
npm run lint
)npm run test
)