Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes .from docs for sprite and tiling sprite #6314

Merged
merged 1 commit into from Jan 7, 2020
Merged

Fixes .from docs for sprite and tiling sprite #6314

merged 1 commit into from Jan 7, 2020

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Jan 7, 2020

Description of change

Brings documentation for Sprite and TilingSprite in line with changes made in #6034 when number was removed as an option in the .from function

Pre-Merge Checklist
  • Documentation is changed or added

bigtimebuddy
bigtimebuddy approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@bigtimebuddy bigtimebuddy merged commit 7a8907f into dev Jan 7, 2020
@bigtimebuddy bigtimebuddy deleted the fix-sprite-docs branch January 7, 2020 22:41
laino pushed a commit to laino/pixi.js that referenced this pull request Jan 10, 2020
@Zyie @laino
Fix docs for Sprite and TilingSprite (pixijs#6314)
b1fdcbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@themoonrat themoonrat themoonrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zyie @bigtimebuddy @themoonrat