Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe from baseTexture loaded event on Texture::destroy #6534

Merged
merged 2 commits into from Apr 10, 2020

Conversation

maximgavrilov
Copy link
Contributor

Description of change

Texture should not receive onBaseTextureUpdated once destroyed. But it left 'loaded' event subscription active.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Apr 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #6534 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6534   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files          38       38           
  Lines        1902     1902           
=======================================
  Hits         1567     1567           
  Misses        335      335           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fbd800...9bbac49. Read the comment docs.

@bigtimebuddy bigtimebuddy merged commit 7bd59ce into pixijs:dev Apr 10, 2020
@bigtimebuddy
Copy link
Member

Thank you @maximgavrilov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants