Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ismobilejs breakage #6551

Merged
merged 1 commit into from Apr 14, 2020
Merged

Fix ismobilejs breakage #6551

merged 1 commit into from Apr 14, 2020

Conversation

bigtimebuddy
Copy link
Member

This was bumping up in a few places namely: #6550 #6546 #6511

Since the release of ismobilejs@1.1.0, there's no longer a default user-agent/navigator argument. This was breaking for our users trying to build against ismobilejs@^1.0.3

@bigtimebuddy bigtimebuddy added the 🔥 High Priority These are PRs or issues that are extremely important to address either because they are from sponsor label Apr 13, 2020
@bigtimebuddy bigtimebuddy changed the title Bump ismobilejs Fix ismobilejs breakage Apr 13, 2020
@bigtimebuddy
Copy link
Member Author

Example:
https://jsfiddle.net/bigtimebuddy/8evch59z/

andrewstart
andrewstart approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@andrewstart andrewstart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their type definitions have a breaking change, while the code itself continues to recognize the parameter as optional. Ugh.

@bigtimebuddy bigtimebuddy merged commit 876b16d into dev Apr 14, 2020
@bigtimebuddy bigtimebuddy deleted the bugfix/ismobilejs branch April 14, 2020 00:39
bigtimebuddy added a commit that referenced this pull request Apr 14, 2020
@bigtimebuddy
Fix ismobilejs breakage (#6551)
c8e1531
@bigtimebuddy bigtimebuddy mentioned this pull request Apr 14, 2020
Merged
This was referenced May 13, 2020
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@andrewstart andrewstart andrewstart approved these changes

Assignees
No one assigned
Labels
🔥 High Priority These are PRs or issues that are extremely important to address either because they are from sponsor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bigtimebuddy @ivanpopelyshev @andrewstart