Change the default BitmapFont texture size #6643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #6643 +/- ##
=======================================
Coverage 76.84% 76.84%
=======================================
Files 29 29
Lines 1127 1127
=======================================
Hits 866 866
Misses 261 261 Continue to review full report at Codecov.
|
|
yeah, good shout! we could get an accurate enough size by |
GoodBoyDigital
approved these changes
May 25, 2020
ShukantPal
approved these changes
May 28, 2020
bigtimebuddy
added
the
✅ Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6600
The default size for generating BitmapFonts was 2048x2048, which is a very large image. Even if most of that is empty space, it's a big memory footprint for the GPU. I turned it down to something a little more reasonable: 512x512.
@SukantPal said that he might work on a heuristic to determine the optimal size based on the font size and character count. Until then, let's turn it down a bit.
Even if not all glyphs fit, they are spread across multiple pages, for instance:
https://jsfiddle.net/bigtimebuddy/et2boa51/