Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for scaling b/w sourceFrame β†’ destinationFrame in ScissorSystem #6867

Merged
merged 3 commits into from Sep 14, 2020
Merged

Account for scaling b/w sourceFrame β†’ destinationFrame in ScissorSystem #6867

merged 3 commits into from Sep 14, 2020

Conversation

ShukantPal
Copy link
Member

@ShukantPal ShukantPal commented Sep 12, 2020 •
edited

@ShukantPal ShukantPal requested a review from a team September 12, 2020 00:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2020 •
edited

Codecov Report

Merging #6867 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #6867   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          671       671           
=========================================
  Hits           671       671

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 857452a...4f594bb. Read the comment docs.

@ShukantPal ShukantPal changed the title Account for scaling b/w sourceFrame β†’ destinationFrame Account for scaling b/w sourceFrame β†’ destinationFrame in ScissorSystem Sep 12, 2020
@bigtimebuddy
Copy link
Member

Example?

@ShukantPal ShukantPal mentioned this pull request Sep 12, 2020
Closed
@ShukantPal
Copy link
Member Author

@bigtimebuddy https://codepen.io/sukantpal/pen/mdPLvJG?editors=0010!

@ShukantPal
Copy link
Member Author

A parallel issue I found was #6871. The pen makes sure to bypass it.

@bigtimebuddy bigtimebuddy added this to the v5.4.0 milestone Sep 14, 2020
@bigtimebuddy bigtimebuddy added the βœ… Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Sep 14, 2020
GoodBoyDigital
GoodBoyDigital approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bigtimebuddy bigtimebuddy merged commit d6b5231 into dev Sep 14, 2020
@bigtimebuddy bigtimebuddy deleted the fix/6866 branch September 14, 2020 21:43
@dev7355608 dev7355608 mentioned this pull request Apr 23, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@GoodBoyDigital GoodBoyDigital GoodBoyDigital approved these changes

Assignees
No one assigned
Labels
βœ… Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

ScissorSystem does not account for scale in sourceFrame β†’ destinationFrame projection
5 participants
@ShukantPal @codecov-commenter @bigtimebuddy @ivanpopelyshev @GoodBoyDigital