Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AnimatedSprite.textures type annotation #7143

Merged

Conversation

ash-r1
Copy link

@ash-r1 ash-r1 commented Jan 12, 2021

Description of change

I met an incorrect type definition for PIXI.AnimatedSprite's textures setter. on 5.3.x.
I realized annotation is different from a real .ts code, so I just adjusted.

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

I don't know which base branch is better to be merged.
but I expect this PR will be merged into 5.3.x and release as 5.3.8 or later.

btw, I read CONTRIBUTING.md but there is no master branch anymore. Is it (a little bit) outdated?

@codecov-io
Copy link

Codecov Report

Merging #7143 (9cd3e5c) into v5.3.x (dacad3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            v5.3.x     #7143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          704       704           
=========================================
  Hits           704       704           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dacad3a...9cd3e5c. Read the comment docs.

@bigtimebuddy bigtimebuddy added this to the v5.3.8 milestone Jan 12, 2021
@bigtimebuddy
Copy link
Member

Thank you for the fix @ash-r1 👍

@ash-r1
Copy link
Author

ash-r1 commented Jan 12, 2021

@bigtimebuddy Thanks quick response! 😄

@bigtimebuddy
Copy link
Member

I was in the middle of working on a few PRs :)

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jan 12, 2021
@bigtimebuddy bigtimebuddy merged commit be1a41b into pixijs:v5.3.x Jan 13, 2021
@bigtimebuddy
Copy link
Member

Thank you @ash-r1, I also added a PR #7149 for those typos in the contributing doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants