Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for missing optional options and param #7151

Merged
merged 1 commit into from Jan 14, 2021

Conversation

bigtimebuddy
Copy link
Member

Issues reported by users on Slack in 6.0.0-rc.2

  • TextStyle constructor arg is optional
  • Application plugin options are optional

cc
@miltoncandelero
@tomasfreres

@codecov-io
Copy link

Codecov Report

Merging #7151 (f7e3db2) into dev (3a84e9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #7151   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          699       699           
=========================================
  Hits           699       699           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a84e9e...f7e3db2. Read the comment docs.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jan 14, 2021
@bigtimebuddy bigtimebuddy merged commit 99d5d41 into dev Jan 14, 2021
@bigtimebuddy bigtimebuddy deleted the fix-optional-types branch January 14, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants