Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings fix for LoaderResource texture #7382

Merged
merged 1 commit into from Apr 5, 2021
Merged

Conversation

ivanpopelyshev
Copy link
Collaborator

@ivanpopelyshev ivanpopelyshev commented Apr 4, 2021

The interface Texture in GLobalMixins is mostly empty, its for mixins, so we cant really pass that interface to actual methods

Currently this fails:

new Sprite(resources['atlas'].textures['apple.png']);

Test: https://codesandbox.io/s/pixitilemap-typings-test-m5pb8?file=/src/index.ts

Uncomment line 16, get an error

@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #7382 (bb5912f) into dev (a777d7a) will not change coverage.
The diff coverage is n/a.

❗ Current head bb5912f differs from pull request most recent head d9b42a0. Consider uploading reports for the commit d9b42a0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #7382   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          699       699           
=========================================
  Hits           699       699           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a777d7a...d9b42a0. Read the comment docs.

@bigtimebuddy
Copy link
Member

Good catch

@bigtimebuddy bigtimebuddy added this to the v6.0.2 milestone Apr 4, 2021
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Apr 5, 2021
@bigtimebuddy bigtimebuddy merged commit 3cfde60 into dev Apr 5, 2021
@bigtimebuddy bigtimebuddy deleted the types-spritesheet-texture branch April 5, 2021 16:30
bigtimebuddy pushed a commit that referenced this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants