Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: V8 text stroke is applied even with width 0. Also strokeThickness does not update at runtime #10426

Open
Unwarped opened this issue Apr 8, 2024 · 1 comment · Fixed by #10496
Assignees

Comments

@Unwarped
Copy link

Unwarped commented Apr 8, 2024

Current Behavior

If you set the strokeThickness to 0, it still applies the text stroke. I made a V7 and V8 playground to show the difference.

V7 playground
V8 playground

You can tell the text looks thicker.

Zyie determined that setting width to 0.00001 or a small decimal number fixed it. Removing stroke or setting to null also works. But 0 does not.

Also, if you try to change strokeThickness at runtime, it does not update. I talked with doormat23 and he believes it is a caching issue. Here is a playground to demonstrate.

Changing text strokeThickness at runtime Playground

Expected Behavior

With strokeThickness 0 there should be no stroke and the text looks slimmer.

And changing it at runtime should update the thickness

Steps to Reproduce

See playgrounds above

Environment

  • pixi.js version: e.g. 8.0.5

Possible Solution

No response

Additional Information

Thanks guys!

@Unwarped
Copy link
Author

Unwarped commented May 1, 2024

Changing strokeThickness at runtime still seems to be broken when I change the playground version to latest 8.1.1

@Zyie Zyie reopened this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants