Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetLoader incompability with Google Closure Compiler #1097

Closed
ullabrittandersson opened this issue Oct 27, 2014 · 2 comments
Closed

AssetLoader incompability with Google Closure Compiler #1097

ullabrittandersson opened this issue Oct 27, 2014 · 2 comments
Labels
🕷 Bug Verified that it’s actually a legit bug that exists in the current release.
Milestone

Comments

@ullabrittandersson
Copy link

When minifying a project with the minified pixi.js included, AssetLoader.load throws an error: "png is an unsupported file type".
This is because the minifyer used by PIXI strips the quotation marks of the types in loadersByType.

I don't know if this is counted as a bug but it presents a problem when working with browserify and google closure compiler.

@tleunen
Copy link

tleunen commented Oct 27, 2014

You should not include a minified version of pixi during your minifying process.
Instead, you can try to include the unminified version. That might work. (That's what I do for a project and everything is working fine after a few tweaks, but I'm not using AssetLoader).

The other solution would be to create an extern file for Pixi (I started to build one but this is not complete). And when you minify your code, you specify the extern file so it won't rename PIXI variables.

@englercj englercj mentioned this issue Dec 26, 2014
@englercj englercj added this to the v3.0 milestone Jan 8, 2015
@englercj englercj closed this as completed Jan 8, 2015
@englercj englercj added the 🕷 Bug Verified that it’s actually a legit bug that exists in the current release. label Feb 21, 2015
@lock
Copy link

lock bot commented Feb 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕷 Bug Verified that it’s actually a legit bug that exists in the current release.
Projects
None yet
Development

No branches or pull requests

3 participants