PIXI.Texture.fromCanvas with CanvasRenderer doesn't work

[MarxGames]

I created a CanvasRenderer and tried to save a big rendered map to texture to optimize it a bit since it was a static map. However it only seemed to work when I was using a WebGLRenderer.

Made a demo http://jsfiddle.net/3SVGY/2/
Just switch the renderer to Canvas to see that it doesnt work

[GoodBoyDigital]

Thanks for this, I will be working on renderTextures next so that will fix this issue for sure :)

[yomotsu]

it seems the issue has been caused from missing pass to img
http://jsfiddle.net/3SVGY/6/

[yomotsu]

however, CanvasRenderer has another issue which caused from drawImage() and frame of PIXI.Texture

drawImage() doesn't work when large size was applied as argument
this means, CanvasRenderer can't display objects which has too large size frame

here are demos

• this will work
  https://dl.dropbox.com/u/1236764/pixijs/drawimage/demo1.html
• this will not work
  https://dl.dropbox.com/u/1236764/pixijs/drawimage/demo2.html

[GoodBoyDigital]

Is that because the frame is bigger than the image being drawn itself?

[yomotsu]

that's right. so when frame was set, it may be better to check sizes

[GoodBoyDigital]

Sounds like a plan!
Will figure out a neat way to check when textures are created / updated that the frame is not too large. That way we wouldn't have to introduce a check every frame.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.