Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when building pixi.js with Closure Compiler #1260

Closed
sbondor opened this issue Dec 9, 2014 · 2 comments
Closed

Errors when building pixi.js with Closure Compiler #1260

sbondor opened this issue Dec 9, 2014 · 2 comments
Milestone

Comments

@sbondor
Copy link

sbondor commented Dec 9, 2014

If I build pixi.dev.js with closure compiler using --warning_level VERBOSE, I get the following errors:

source/vendor/pixi.js/bin/pixi.dev.js:13901: ERROR - variable slot is undeclared
if (slots[i].name == slotName) return slot[i];
^

source/vendor/pixi.js/bin/pixi.dev.js:14052: ERROR - variable time is undeclared
time += delta;
^

source/vendor/pixi.js/bin/pixi.dev.js:15879: ERROR - variable event is undeclared
if( event.type === 'canplaythrough' )
^

source/vendor/pixi.js/bin/pixi.dev.js:18172: ERROR - variable exports is undeclared
if (typeof exports !== 'undefined') {
^

source/vendor/pixi.js/bin/pixi.dev.js:18173: ERROR - variable module is undeclared
if (typeof module !== 'undefined' && module.exports) {
^

source/vendor/pixi.js/bin/pixi.dev.js:18177: ERROR - variable define is undeclared
} else if (typeof define !== 'undefined' && define.amd) {
^

Plus a ton of warnings which I'm not going to list here...

@englercj englercj mentioned this issue Dec 26, 2014
@englercj englercj added this to the v3.0 milestone Jan 8, 2015
@englercj
Copy link
Member

Fixed in v3, just confirmed the new build works fine with closure compiler. There are a few warnings with the browserify bundle, mostly because it doesn't like things like !function(){} which is a common way of making a function be evaluated as an expression.

@lock
Copy link

lock bot commented Feb 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants