Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture Cache #41

Closed
ze0nni opened this issue Apr 2, 2013 · 4 comments
Closed

Texture Cache #41

ze0nni opened this issue Apr 2, 2013 · 4 comments

Comments

@ze0nni
Copy link
Contributor

ze0nni commented Apr 2, 2013

Caching for PIXI.Texture.fromCanvas() return first cached texture.
it is wrong to use 'canvas' as key for TextureCache[] and BaseTextureCache[]
Also I it think caching for canvas is bad idea, because canvas can change content.

@GoodBoyDigital
Copy link
Member

Thanks ze0nni! Yes that makes total sense. Fancy implementing the changes? and I can push it into the master branch.

@ze0nni
Copy link
Contributor Author

ze0nni commented Apr 4, 2013

Ok. Send pull reqest. I have not found how attach commit here.

@GoodBoyDigital
Copy link
Member

all merged, thanks for the pull! 👍

@lock
Copy link

lock bot commented Feb 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants