Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.5.0-rc.4 pixi.js package has invalid @pixi/canvas-renderer dependency #8516

Closed
Julien-Marcou opened this issue Jul 21, 2022 · 1 comment · Fixed by #8517
Closed

v6.5.0-rc.4 pixi.js package has invalid @pixi/canvas-renderer dependency #8516

Julien-Marcou opened this issue Jul 21, 2022 · 1 comment · Fixed by #8517

Comments

@Julien-Marcou
Copy link
Member

Julien-Marcou commented Jul 21, 2022

Expected Behavior

After upgrading a project from the v6.4.2 to the v6.5.0-rc.4 I shouldn't have any errors.

Current Behavior

Error: node_modules/@pixi/app/index.d.ts:4:37 - error TS2307: Cannot find module '@pixi/canvas-renderer' or its corresponding type declarations.

4 import type { CanvasRenderer } from '@pixi/canvas-renderer';
                                      ~~~~~~~~~~~~~~~~~~~~~~~
Error: node_modules/@pixi/settings/index.d.ts:3:37 - error TS2307: Cannot find module 'ismobilejs' or its corresponding type declarations.

3 import type { isMobileResult } from 'ismobilejs';
                                      ~~~~~~~~~~~~

@pixi/app has a dependency to @pixi/canvas-renderer that was not present in the v6.4.2, as pixi.js is described PixiJS without the CanvasRenderer fallback, modern browsers only I think this dependency should not be present.

As for the isMobileResult, I think it is related to #8502 that is not fully fixed yet.

Steps to Reproduce

git clone git@github.com:Julien-Marcou/puzzle.git
cd puzzle/front
git checkout pixi-6.5
npm install
npm run start

Environment

  • pixi.js version: v6.5.0-rc.4
@bigtimebuddy
Copy link
Member

These should be easy to sort. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants