Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any way to add support for ios9? #19

Closed
hendrysadrak opened this issue Jun 19, 2017 · 5 comments
Closed

Is there any way to add support for ios9? #19

hendrysadrak opened this issue Jun 19, 2017 · 5 comments

Comments

@hendrysadrak
Copy link
Contributor

hendrysadrak commented Jun 19, 2017

Currently getting error Error: InvalidStateError: DOM Exception 11 when calling PIXI.sound.play('soundName');

@bigtimebuddy
Copy link
Member

Is this error thrown with the examples?

@hendrysadrak
Copy link
Contributor Author

The examples dont work because of ES6 syntax :D

@bigtimebuddy
Copy link
Member

Looks like a pretty easy fix. I added this to the dev branch, but will also probably make a patch release to master for this. The offending line is here:

https://github.com/pixijs/pixi-sound/blob/master/src/SoundInstance.ts#L245

this._source.start(0, start, (end ? end - start : undefined));

For iOS 9, this should be:

if (end) {
  this._source.start(0, start,  end - start);
} else {
  this._source.start(0, start);
}

@hendrysadrak
Copy link
Contributor Author

Perfect! Thank you for the quick response! When will you merge dev to master or create a patch?

@bigtimebuddy
Copy link
Member

Released in v1.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants