Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop doesn't work on sound sprite #57

Closed
barvynkoa opened this issue Mar 13, 2018 · 5 comments
Closed

Loop doesn't work on sound sprite #57

barvynkoa opened this issue Mar 13, 2018 · 5 comments

Comments

@barvynkoa
Copy link

Seems like loop doesn't work correctly in this situation

this.sound = Sound.from({
	url: this.audioPath,
	sprites: this.sprites
});
this.sound.play({
	sprite: soundName,
	loop: true
});

Sound just play once...

examples
looping https://jsfiddle.net/8f5pvrq2/4/
not looping, why? https://jsfiddle.net/uxzrq04b/12/

Is it a bug? does anybody know how it should work?

@barvynkoa
Copy link
Author

Aha, it is because of this
https://andrii.tinytake.com/sf/MjQ1MzE3OV83NDA5MjE5

Looping not support when specifying an "end" time

sadly

@bigtimebuddy
Copy link
Member

I think I originally didn't implement looping on sprites because I had assumed there would be obvious seaming issues on the fallback HTML5 element. I'm willing to change this and maybe add a warning about it in the documentation.

@barvynkoa
Copy link
Author

thank you for you response

from my point of view it is will be great have sign in documentation

Honestly I don't understand about what kind of issues in the fallback HTML5 element you are talking about. If you have a time, could you please clarify a bit more?

Looping sound is a very important feature, but if it may cause a problems with sound sprites you know... I won't use sound sprite

@rhausmair
Copy link

any chance to get that implemented in the next release?

@bigtimebuddy
Copy link
Member

Added with #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants