Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect rendering in canvas mode, when atlas file reference an image with rotate: 90 #460

Open
magos1983 opened this issue Sep 29, 2022 · 7 comments
Assignees

Comments

@magos1983
Copy link

magos1983 commented Sep 29, 2022

as you can see in this image it looks like width/height or scale is wrong (webgl is rendered correctly)
image

here is my code sample: https://codesandbox.io/s/heuristic-shape-h5kf9l

You can force canvas renderer or launch a browser with disabled webgl (e.g chrome with this flag: --args -disable-webgl)

The product we develop needs to run some automated tests on a linux box where webgl is not available, it can also be that the end users browser may no support webgl...

pixi-spine version: 3.1.0
pixi version: 6.5.4

@magos1983 magos1983 changed the title incorrect rendering in canvas mode, when atlas file reference an image with rotate incorrect rendering in canvas mode, when atlas file reference an image with rotate: 90 Sep 29, 2022
@ivanpopelyshev
Copy link
Collaborator

That's interesting. rotation code is mine, gonna investigate what went wrong

@ivanpopelyshev ivanpopelyshev self-assigned this Sep 29, 2022
@magos1983
Copy link
Author

Thanks @ivanpopelyshev, please let me know if you need more information or other samples. Hopefully the code sandbox link is working for you.

@ivanpopelyshev
Copy link
Collaborator

Temporary fix: https://codesandbox.io/s/white-meadow-boynnd?file=/src/index.js

it looks like we broke something in 6.5.3

@magos1983
Copy link
Author

Thanks for the patch, I will test it. Maybe a fix can be included in pixi 6.x?

@ivanpopelyshev
Copy link
Collaborator

ivanpopelyshev commented Sep 29, 2022

I created an issue, we have to investigate which version is actually correct. It might be that texture packer that was used to make that pull request works differently than TexturePacker :)

Look two posts above

@ivanpopelyshev
Copy link
Collaborator

I fixed the patch, try again )

@magos1983
Copy link
Author

I have tested it as well, works correctly. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants