Don't try to open files in the distribution for writing #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When imported into OpenBSD, this will be attempted to run from a readonly source tree. This test fails in that situation because we are not allowed to open t/truncate_me for writing. Instead, we can just use the tempfile.
|
This looks good to me, and travis loves it, so I'm merging. I know I was trying to clean up #35 before doing a release, but honestly what we have now is better than what we had before, and since my release criterion is purely "better than the previous release", I'll try and roll this out now. :) Thanks for being awesome! Paul |
pjf
added a commit
that referenced
this pull request
Mar 30, 2014
Don't try to open files in the distribution for writing
pjf
added a commit
that referenced
this pull request
Mar 30, 2014
pjf
added a commit
that referenced
this pull request
Mar 30, 2014
* FEATURE: Provide a stack backtrace when `Carp::Always` is enabled.
Note that sometimes this is not as pretty as it could
be, patches welcome.
(Thanks to Niels Thykier, GH #35)
* BUGFIX: Fix situations where `no autodie` doesn't respect lexical
scope. (Thanks to Niels Thykier, GH #41, RT #72053,
RT #86396)
* INTERNAL: Remove now unused variables in code (Niels Thykier).
* DOCS: Make it extra-clear autodie doesn't check `print`.
(Dave Rolsky, GH #39)
* TEST: Removed obsolete boilerplate.t
* TEST / INTERNAL: Enabled travis-ci for Perl 5.8
* TEST: Stopped some Pod::Coverage tests failing under Perl 5.8
* BUILD: Better support for building in a read-only directory
(courtesy Andrew Fresh, GH #46)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When imported into OpenBSD, this will be attempted to run from a
readonly source tree. This test fails in that situation because we are
not allowed to open t/truncate_me for writing.
Instead, we can just use the tempfile.