Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Compression #6

Closed
GoogleCodeExporter opened this issue Apr 26, 2015 · 6 comments
Closed

Allow Compression #6

GoogleCodeExporter opened this issue Apr 26, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

It would be nice if sending with compression was supported.  I was able to 
enable compression by adding the following to the getPipeline() function in the 
channel pipeline factories:

p.addLast("deflater", new ZlibEncoder(ZlibWrapper.GZIP));
p.addLast("inflater", new ZlibDecoder(ZlibWrapper.GZIP));

However, it would be nice as an optional feature.  It would also be nice if the 
server could dynamically detect from the frame whether the data being sent is 
compressed to support compressed and uncompressed clients simultaneously. 

Original issue reported on code.google.com by kryptoni...@gmail.com on 17 Apr 2012 at 2:44

@GoogleCodeExporter
Copy link
Author

nice. I'll look into integrating this as a feature and what it would take to 
provide dual-mode support. Thanks;P.

Original comment by pjklauser@gmail.com on 17 Apr 2012 at 6:00

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

I'll make a 1.2.0 version of the lib - and upgrade the netty to netty.io dep.

Original comment by pjklauser@gmail.com on 22 Apr 2012 at 8:14

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

deployed with 1.2.0: try to use the 
DuplexTcpClientBootstrap#setCompression(true) on each client you want to use 
compression with.

Original comment by pjklauser@gmail.com on 22 Apr 2012 at 11:29

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Thanks, I will test it out.

Original comment by kryptoni...@gmail.com on 23 Apr 2012 at 12:45

@GoogleCodeExporter
Copy link
Author

It works great, I appreciate it!

Original comment by kryptoni...@gmail.com on 23 Apr 2012 at 8:22

@GoogleCodeExporter
Copy link
Author

Original comment by pjklauser@gmail.com on 26 Nov 2012 at 10:53

  • Changed state: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant