Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SIP UPDATE (RFC 3311) and fix the offer/answer negotiation #2272

Closed
pjsipbot opened this issue Nov 24, 2006 · 0 comments
Closed

Comments

@pjsipbot
Copy link
Collaborator

2006-11-24 11:51:33: @bennylp created the issue on trac ticket 5

SIP UPDATE is specified in RFC 3311 for updating session parameters without affecting dialog's state.

Also to be fixed in this development is the offer/answer negotiation in pjsip's invite session, since with the support for UPDATE (and PRACK) there are more offer and answer scenarios to support.


2007-10-03 19:24:55: @bennylp changed priority from minor to normal


2007-10-03 19:24:55: @bennylp changed milestone from unassigned to release-0.7.1


2007-10-03 19:24:55: @bennylp edited the issue description


2007-10-03 19:24:55: @bennylp changed title from Support for SIP UPDATE (RFC 3311) to Support for SIP UPDATE (RFC 3311) and fix the offer/answer negotiation


2007-10-03 19:31:57: @bennylp changed status from new to closed


2007-10-03 19:31:57: @bennylp set resolution to fixed


2007-10-03 19:31:57: @bennylp commented

Implemented in r1469:

  • UPDATE is now supported! Use pjsip_inv_update() to send UPDATE with offer.
  • PRACK implementation has been heavily modified since it is strictly coupled with the invite session's offer and answer session.
  • Because of above, PRACK support cannot be made optional anymore. The PJSIP_HAS_100REL configuration has been removed.
  • Fixed the offer/answer negotiation to support all scenarios (see below)
  • Added test module in test_pjsip application to test various offer/answer scenarios
  • Changed dialog to send Allow header in 1xx response, so that UAC can detect support for UPDATE
  • Minor fix in sip_transaction.c to make the pool's obj_name equal to the transaction's obj_name.

Supported offer and answer scenarios:

  • The usual INVITE with offer
  • INVITE with no offer will cause UAS to send offer in 18x or 2xx response. When 100rel is used, answer will be provided in PRACK, otherwise answer will be provided in ACK.
  • Sending and receiveing UPDATE containing new offer.

2007-10-04 07:39:45: @bennylp commented

Related to this, ticket #389 adds new commands in pjsua application to change codec orders and send UPDATE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants